feat: add pagination to item_tags index API#34
Merged
Conversation
- Create pagy initializer with default limit 20 - Include Pagy::Method in shopkeeper base controller with pagy_meta helper - Paginate item_tags index: limit 20 with page param, 1000 without (backward compat) - Add meta object (current_page, total_pages, total_count, limit) to response - Add page query param and meta schema to openapi.yaml - Add pagination-item-tags.md design doc - Add pagination tests: meta presence, backward compat, paginated, overflow Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/shopkeeper/shops/{shop_id}/item_tagspageparam: returns 20 items per page (Pagy default)pageparam: returns up to 1000 items (backward compat for ShopDetailView)metaobject withcurrent_page,total_pages,total_count,limitpagequery param andmetaresponse schemaTest plan
bin/cipassespageparampage=1returns correct meta🤖 Generated with Claude Code